-
Notifications
You must be signed in to change notification settings - Fork 183
Update two links for AWS in CSPM documentation #4150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing the wrong links
✅ Vale Linting ResultsNo issues found on modified lines! |
🔍 Preview links for changed docs |
florent-leborgne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these are supposed to keep users on the same page since these sections are visibly there too. The current links and the suggested fixes send users to a different page, which looks strange to me, and if correct would make me question why do we have those sections after on the page :D
Thanks for finding them and attempting a fix.
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
benironside
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it must be a bug, but using just the local anchor tags that Florent suggested resulted in switching to another page that also has the same anchor tags. I'm going to try using full explicit links to make this work as expected and stay on the same page.
|
Tested the links in the preview and they're now working. |
Dismissing Florent's review because I updated the links and tested them in the preview, and they're now working.
As following the same principle below described in #4150: > I think these are supposed to keep users on the same page since these sections are visibly there too. changing the link to the same doc rather than pointing the different page
As following the same principle below described in #4150: > I think these are supposed to keep users on the same page since these sections are visibly there too. changing the link to the same doc rather than pointing the different page ## Generative AI disclosure <!-- To help us ensure compliance with the Elastic open source and documentation guidelines, please answer the following: --> 1. Did you use a generative AI (GenAI) tool to assist in creating this contribution? - [ ] Yes - [x] No <!-- --------- Co-authored-by: florent-leborgne <florent.leborgne@elastic.co>
Fixing the wrong links
Summary
Fixing two wrong link with azure to aws
Generative AI disclosure