Skip to content

Conversation

@kunisen
Copy link
Contributor

@kunisen kunisen commented Dec 11, 2025

Summary

This is to address https://github.com/elastic/docs-content-internal/issues/592.

I am raising this as the first PR to decide the wording with docs, and ES dev / PM team. Thanks!

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

Preview / View

Before PR merge

deploy-manage/deploy/self-managed/vm-max-map-count.md

After PR merge

https://www.elastic.co/docs/deploy-manage/deploy/self-managed/vm-max-map-count

@kunisen kunisen requested review from bytebilly and lkts December 11, 2025 08:21
@kunisen kunisen self-assigned this Dec 11, 2025
@kunisen kunisen requested a review from a team as a code owner December 11, 2025 08:21
@kunisen kunisen added documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team labels Dec 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

Vale Linting Results

Summary: 1 suggestion found

💡 Suggestions (1)
File Line Rule Message
deploy-manage/deploy/self-managed/vm-max-map-count.md 13 Elastic.WordChoice Consider using 'can, might' instead of 'may', unless the term is in the UI.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

🔍 Preview links for changed docs

Copy link
Contributor

@yetanothertw yetanothertw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

kunisen and others added 2 commits December 12, 2025 00:10
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
@kunisen
Copy link
Contributor Author

kunisen commented Dec 11, 2025

Thank you @yetanothertw for the review and valuable advice as always! 🙏
I will wait for engineering / PM's input & review before I go merge. Thanks for your patience.


By the way, may I have one question about format please?
https://docs-v3-preview.elastic.dev/elastic/docs-content/pull/4295/deploy-manage/deploy/self-managed/vm-max-map-count

I see the admonition directive doesn't seem to show markdown format but shows "`" as is.

image

My question is, should I use ` to quote, or should I avoid using the it? To be more specific, should I do A) or B) please?

  • A)
Verify `vm.max_map_count` configuration
  • B)
Verify vm.max_map_count configuration

Copy link

@lkts lkts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for driving this change. I have one suggestion, otherwise LGTM.

@shainaraskas
Copy link
Collaborator

is this something that should be checked on upgrade, too? that's what I gathered from a couple of the slack conversations

@kunisen
Copy link
Contributor Author

kunisen commented Dec 12, 2025

Thanks @shainaraskas

is this something that should be checked on upgrade, too? that's what I gathered from a couple of the slack conversations

Yes. We should check this value when ES upgrade to 8.16+.

However, it's OS setting so I am unsure if we can let ES API (migration APIs) or Kibana upgrade assistant detect it and do the suggestion.

I think from docs perspective, we can add one section like "review your prerequisite settings", and this vm.max_map_count belongs to Increase virtual memory which is also part of the Important system configuration, which can be considered as "prerequisites".

From support and doc perspective, I think we may want to have this as an essential section, to make sure we can cover the things we need. (Another essential section we'd think could be important, is a reference to known issue. We may want to add that to help customer skip some version or take some prevention steps before things become too late after they upgrade)


But it's not my area (cloud) so I'd like to defer to ES friends (@bytebilly @lkts) for insights on this.

@kunisen kunisen enabled auto-merge (squash) December 12, 2025 03:18
@kunisen
Copy link
Contributor Author

kunisen commented Dec 12, 2025

I will do merge given we got approval from both ES and doc teams. Thank you all for the great help!

@kunisen kunisen merged commit 8679c3e into main Dec 12, 2025
8 checks passed
@kunisen kunisen deleted the kunisen-docpr-dci-592-1 branch December 12, 2025 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation supportability ability enable self-service or support of product Team:Admin Issues owned by the Admin Docs Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants