-
Notifications
You must be signed in to change notification settings - Fork 190
Change vm.max_map_count default to 1048576 in All ES docs for version 8.16+ #4295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Vale Linting ResultsSummary: 1 suggestion found 💡 Suggestions (1)
|
🔍 Preview links for changed docs |
yetanothertw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you!
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
|
Thank you @yetanothertw for the review and valuable advice as always! 🙏 By the way, may I have one question about format please? I see the admonition directive doesn't seem to show markdown format but shows "`" as is.
My question is, should I use ` to quote, or should I avoid using the it? To be more specific, should I do A) or B) please?
|
lkts
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for driving this change. I have one suggestion, otherwise LGTM.
|
is this something that should be checked on upgrade, too? that's what I gathered from a couple of the slack conversations |
Co-authored-by: Vlada Chirmicci <vlada.chirmicci@elastic.co>
|
Thanks @shainaraskas
Yes. We should check this value when ES upgrade to 8.16+. However, it's OS setting so I am unsure if we can let ES API (migration APIs) or Kibana upgrade assistant detect it and do the suggestion. I think from docs perspective, we can add one section like "review your prerequisite settings", and this From support and doc perspective, I think we may want to have this as an essential section, to make sure we can cover the things we need. (Another essential section we'd think could be important, is a reference to known issue. We may want to add that to help customer skip some version or take some prevention steps before things become too late after they upgrade) But it's not my area (cloud) so I'd like to defer to ES friends (@bytebilly @lkts) for insights on this. |
|
I will do merge given we got approval from both ES and doc teams. Thank you all for the great help! |

Summary
This is to address https://github.com/elastic/docs-content-internal/issues/592.
I am raising this as the first PR to decide the wording with docs, and ES dev / PM team. Thanks!
Generative AI disclosure
Preview / View
Before PR merge
deploy-manage/deploy/self-managed/vm-max-map-count.md
After PR merge
https://www.elastic.co/docs/deploy-manage/deploy/self-managed/vm-max-map-count