Skip to content

Mount docs source read-only in Docker build container #3328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mpdreamz merged 10 commits into from
May 3, 2026
+5 −2
Merged

Mount docs source read-only in Docker build container #3328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
846f61f
Mount docs source read-only in Docker build container
Mpdreamz May 3, 2026
3b09312
Redirect rubocop cache to /tmp for read-only mount compatibility
Mpdreamz May 3, 2026
1f54098
Add writable overlay for resources/web/tests to allow parcel output
Mpdreamz May 3, 2026
80ed4a2
Move web/tests writable overlay to --docker-run only, not doc builds
Mpdreamz May 3, 2026
8090770
Merge branch 'master' into fix/docker-readonly-mount
Mpdreamz May 3, 2026
5566260
Fix pycodestyle E501 line-too-long on writable overlay mount
Mpdreamz May 3, 2026
02c0370
Ensure web/tests dir exists before bind-mounting to avoid root ownership
Mpdreamz May 3, 2026
3a718ad
Mount tmpfs at /docs_build/.repos for integration test air-gapped setup
Mpdreamz May 3, 2026
5ce7cf1
Add tmpfs for parcel caches and fix rspec_status path
Mpdreamz May 3, 2026
7b7cb2a
Protect .buildkite/hooks with tmpfs instead of making all of /docs_bu…
Mpdreamz May 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ require:

AllCops:
TargetRubyVersion: 2.3
CacheRootDirectory: .rubocop_cache
CacheRootDirectory: /tmp/rubocop_cache
MaxFilesInCache: 1000

Style/ReturnNil:
Expand Down
5 changes: 4 additions & 1 deletion build_docs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@

import errno
import logging
from os import environ, getgid, getuid
from os import environ, getgid, getuid, makedirs
from os.path import basename, dirname, exists, expanduser, isdir
from os.path import join, normpath, realpath
import re
Expand Down Expand Up @@ -556,6 +556,9 @@ def standard_docker_args():
docker_args.extend(['--user', '%d:%d' % (uid, getgid())])
# Mount the docs build code so we can run it!
docker_args.extend(['-v', '%s:/docs_build:cached' % DIR])
# Shadow .buildkite/hooks with an empty tmpfs so any code running inside
# the container cannot plant Buildkite hooks that execute on the host.
docker_args.extend(['--tmpfs', '/docs_build/.buildkite/hooks'])
# Seccomp adds a *devestating* performance overhead if you happen
# to have it installed.
docker_args.extend(['--security-opt', 'seccomp=unconfined'])
Expand Down