Fix docs-build-pr not triggering on elastic/docs PRs#3332
Merged
Conversation
The docs-build-pr pipeline has a branch filter in Buildkite that only allows master. All other repos in job 0 use always_trigger_branch:master so they always build against master and pass the filter. The standalone elastic/docs job (job 1) has no always_trigger_branch, so the pr-bot triggers against the PR's feature branch which the pipeline filter silently rejects. Previously builds appeared to work because the doc-preview GitHub Actions workflow posts a comment containing the text "run docs-build", which accidentally matched the old unanchored trigger_comment_regex. Tightening the regex with ^ and $ anchors (#3327) inadvertently removed that accidental trigger. Setting ignore_pipeline_branch_filters: true tells the Buildkite API to bypass the pipeline's branch filter, allowing build_on_commit and comment triggers to work as intended per the buildkite-pr-bot design. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
cotti
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
docs-build-prBuildkite pipeline has a branch filter configured to only allowmaster. All other repos use job 0 which hasalways_trigger_branch: master— so builds always trigger against the master branch and pass the filter.The standalone
elastic/docsentry (job 1) has noalways_trigger_branch, so the pr-bot triggers against the PR's feature branch, which the pipeline filter silently rejects. No build, no GitHub check.Why it appeared to work before
Previously, builds appeared to trigger because the
doc-previewGitHub Actions workflow posts a comment on every new PR containing the text`run docs-build`. The oldtrigger_comment_regexhad no^/$anchors, so it matched any comment containing "run docs-build" — accidentally triggering a build via the comment path.Tightening the regex with anchors in #3327 correctly stopped that partial match, but also removed the only mechanism that was making it work.
Fix
Add
ignore_pipeline_branch_filters: trueto job 1. This tells the Buildkite API to bypass the pipeline's branch filter when triggering, allowingbuild_on_commitand comment triggers to work as intended per the buildkite-pr-bot design.Security is still enforced by
allow_org_users: trueandallowed_repo_permissions: [admin, write]— external contributors cannot trigger builds.Testing
After merge, verify that PR #3331 (
test/buildkite-docs-build-pr-trigger) shows abuildkite/docs-build-prcheck on the next push orbuildkite test thiscomment.