Fix image path check: anchor to book output dir not chapter dir#3333
Merged
Fix image path check: anchor to book output dir not chapter dir#3333
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
The docs-build-pr pipeline has a branch filter in Buildkite that only allows master. All other repos in job 0 use always_trigger_branch:master so they always build against master and pass the filter. The standalone elastic/docs job (job 1) has no always_trigger_branch, so the pr-bot triggers against the PR's feature branch which the pipeline filter silently rejects. Previously builds appeared to work because the doc-preview GitHub Actions workflow posts a comment containing the text "run docs-build", which accidentally matched the old unanchored trigger_comment_regex. Tightening the regex with ^ and $ anchors (#3327) inadvertently removed that accidental trigger. Setting ignore_pipeline_branch_filters: true tells the Buildkite API to bypass the pipeline's branch filter, allowing build_on_commit and comment triggers to work as intended per the buildkite-pr-bot design. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Mpdreamz
force-pushed
the
fix/image-copy-output-root
branch
from
88077aa to
b48b093
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anchors the image destination check to
outdir(the book-level output directory, e.g.html/en/kibana/8.19/) rather thanto_dir(the chapter subdirectory). This allows legitimate../sibling/image references within a book while still preventing images from escaping the book output root. Also addsoutdirtobuild_singlefor consistency withbuild_chunked.