This repository was archived by the owner on Sep 17, 2024. It is now read-only.
feat: add licenses and support for generating notice files#175
Merged
mdelapenya merged 3 commits intoelastic:masterfrom Jul 17, 2020
Merged
feat: add licenses and support for generating notice files#175mdelapenya merged 3 commits intoelastic:masterfrom
mdelapenya merged 3 commits intoelastic:masterfrom
Conversation
mdelapenya
added
automation
documentation
v1v
approved these changes
Jul 17, 2020
Contributor
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
kuisathaverat
approved these changes
Jul 17, 2020
cachedout
approved these changes
Jul 17, 2020
mdelapenya
commented
Jul 17, 2020
| go get -v -t ./... | ||
|
|
||
| .PHONY: notice | ||
| notice: |
Contributor
Author
There was a problem hiding this comment.
Taken from Beats
mdelapenya
commented
Jul 17, 2020
| godog --format=${FORMAT} ${FEATURE_FLAG} ${FEATURE} | ||
|
|
||
| .PHONY: notice | ||
| notice: |
Contributor
Author
There was a problem hiding this comment.
Taken from Beats
ph
approved these changes
Jul 17, 2020
Contributor
Author
|
@mostlyjason I merged today to make progress with the licenses already merged. Please comment whatever you consider here Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
It's addding Elastic's license to all source code, plus the automation to generate NOTICE.txt from the existing Go depenencies, as used in the Beats project.
Why is it important?
As this is a public repo, we want to be consistent with our Open Source policies
Follow-ups
Because the e2e module is consuming the CLI, we need CLI's license file to be pushed first before submitting the e2e.
As this project is starting to be GA, we will generate a 1.0.0 tag for the CLI