Skip to content

Fix goreleaser config.#627

Merged
gigerdo merged 3 commits intoelastic:masterfrom
gigerdo:fix-goreleaser
Oct 23, 2023
Merged

Fix goreleaser config.#627
gigerdo merged 3 commits intoelastic:masterfrom
gigerdo:fix-goreleaser

Conversation

@gigerdo
Copy link
Member

@gigerdo gigerdo commented Oct 23, 2023

Updates to latest goreleaser, fixes all configs/parameters that are deprecated with this release.

The 'replacements' parameter was removed in goreleaser. The name now has to be built directly in the file-name template.

(See: goreleaser/goreleaser#3588 (comment))

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

The 'replacements' parameter was removed in goreleaser. The name now has to be built directly in the file-name template.

(See: goreleaser/goreleaser#3588 (comment))
@gigerdo gigerdo marked this pull request as ready for review October 23, 2023 09:56
@gigerdo gigerdo requested a review from a team as a code owner October 23, 2023 09:56
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gigerdo gigerdo merged commit 74e63ed into elastic:master Oct 23, 2023
@gigerdo gigerdo deleted the fix-goreleaser branch October 23, 2023 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants