Merged
Conversation
gigerdo
force-pushed
the
fix-goreleaser-action
branch
from
43a0520 to
64bc25b
Compare
gigerdo
force-pushed
the
fix-goreleaser-action
branch
from
64bc25b to
499fa7d
Compare
We were using the 'latest' gorelease-action, which had changed from 1->2 recently. The --rm-dist flag was replaced by --clean Change the config to continue using v1. We can eventually upgrade to v2, but we also need to update golang to 1.23.0 first.
gigerdo
force-pushed
the
fix-goreleaser-action
branch
from
499fa7d to
1e00dd2
Compare
claudia-correia
pushed a commit
to claudia-correia/ecctl
that referenced
this pull request
Nov 18, 2024
The release github action is currently broken: We were using the `latest` gorelease-action, which had changed from 1->2 recently. The main breaking change for us was that `--rm-dist` flag was replaced by `--clean` But this change causes some other changes: - Some smaller changes in the goreleaser config - To run the newest goreleaser, we have to upgrade to golang 1.23.0 - When using go 1.23.0, golangci-lint also needs upgrading - golanci-lint on the new version also has some config deprecations/changes But with all these changes, the local build/lint runs without errors or warnings and the dry-run gorelease also runs through (hopefully the same is the case in the github action).
claudia-correia
added a commit
that referenced
this pull request
Nov 18, 2024
The release github action is currently broken: We were using the `latest` gorelease-action, which had changed from 1->2 recently. The main breaking change for us was that `--rm-dist` flag was replaced by `--clean` But this change causes some other changes: - Some smaller changes in the goreleaser config - To run the newest goreleaser, we have to upgrade to golang 1.23.0 - When using go 1.23.0, golangci-lint also needs upgrading - golanci-lint on the new version also has some config deprecations/changes But with all these changes, the local build/lint runs without errors or warnings and the dry-run gorelease also runs through (hopefully the same is the case in the github action). Co-authored-by: Dominik Giger <dominik.giger@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release github action is currently broken:
We were using the
latestgorelease-action, which had changed from 1->2 recently. The main breaking change for us was that--rm-distflag was replaced by--cleanBut this change causes some other changes:
But with all these changes, the local build/lint runs without errors or warnings and the dry-run gorelease also runs through (hopefully the same is the case in the github action).