Register TypeInfoProvider explicitly #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Mpdreamz
commented
Aug 4, 2025
Mpdreamz
commented
- Add EcsJsonContext.Default to JsonSerializerOptions
- Update JsonSerializerOptions to combine DefaultJsonTypeInfoResolver with EcsJsonContext
- Add JsonSerializable attributes for EcsDocument and Labels in EcsJsonContext
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…and update parser intermediary types
…, add documentation
reakaleek
approved these changes
Aug 5, 2025
| namespace Elastic.CommonSchema.NLog; | ||
|
|
||
| /// <summary> | ||
| /// |
stevejgordon
approved these changes
Aug 5, 2025
Contributor
stevejgordon
left a comment
stevejgordon
left a comment
There was a problem hiding this comment.
LGTM besides a couple of empty XML summaries
Member
Author
|
Thanks @reakaleek @stevejgordon will follow up for the empty xml summaries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.