Skip to content

Conversation

@v1v
Copy link
Member

@v1v v1v commented Feb 28, 2020

What

Release to the AppVeyor when build in the master branch.
No more appveyor based

Why

To remove the dependency with the appveyor.

Tests

See here

An example of a dry-run with some echos!


echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.Apm.NLog.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.Apm.SerilogEnricher.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.CommonSchema.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.CommonSchema.BenchmarkDotNetExporter.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.CommonSchema.NLog.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

echo dotnet nuget push "C:\Users\jenkins\workspace\gent-dotnet_ecs-dotnet-mbp_PR-53\src\go.elastic.co\apm\ecs-dotnet\build\output\Elastic.CommonSchema.Serilog.1.5.0-ci20200228T170655.nupkg" -k "********" -s "********" 

Artefacts are also stored in Jenkins - see here

@v1v v1v self-assigned this Feb 28, 2020
@v1v v1v added the automation label Feb 28, 2020
@v1v v1v requested review from a team, Mpdreamz and codebrain February 28, 2020 17:16
@v1v v1v marked this pull request as ready for review February 28, 2020 17:17
@Mpdreamz
Copy link
Member

Mpdreamz commented Mar 2, 2020

@v1v which feed is this publishing into?

It should go into https://ci.appveyor.com/nuget/ecs-dotnet (can supply an API key for).

The retention on these are limited so best not to share with apm-dotnet-agent

@v1v v1v requested a review from gregkalapos March 3, 2020 12:09
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've disabled the build on appveyor completely as well now as it was falling back on a default MSBuild build without the appveyor.yml file

@v1v v1v merged commit 877b05f into elastic:master Mar 3, 2020
@v1v v1v deleted the feature/ci-nuget branch March 3, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants