-
Notifications
You must be signed in to change notification settings - Fork 67
[backport] AOT Annotations and CI smoke tests for AOT publishes #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Contributor
I was thinking to update the AOT-verification-app to use NLog v6. But keep using NLog v5 for the library ? This will provide the highest level of compatibility (Since not everyone develops AOT-applications) |
…he project file (cherry picked from commit 5476a34)
…irectory.Build.props
flobernd
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AOT annotations for all published projects and ensures they are advertised as AOT compatible.
Create a smoke test binary that writes to an in memory elasticsearch endpoint for our NLog and Extensions loggers.
Serilog is currently failing with:
Will create an issue with Serilog to see if it can be resolved.
This removes https://github.com/benaadams/Ben.Demystifier as its not AOT compatible. AOT compatibility beats nicer stacktrace strings as a feature to keep supporting IMO.
This bumps NLog to 6.0.0 to take benefit of its work to be AOT compatible (cc @snakefoot)
Also be aware wuth this backport we bump NLog to 6.0.0 for our
8.xreleases.We typically do not require major version bumps in our deps to force a bump in our major version. cc @snakefoot