Skip to content

Use a thread local StringBuilder to avoid creating garbage #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use a thread local StringBuilder to avoid creating garbage #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion ...manager-ecs-formatter/src/main/java/co/elastic/logging/jboss/logmanager/EcsFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@

public class EcsFormatter extends ExtFormatter {

private static final ThreadLocal<StringBuilder> STRING_BUILDER = new ThreadLocal<StringBuilder>();

private String serviceName;
private String eventDataset;
private boolean includeOrigin;
Expand All @@ -44,9 +46,21 @@ public EcsFormatter() {
stackTraceAsArray = Boolean.getBoolean(getProperty("co.elastic.logging.jboss.logmanager.EcsFormatter.stackTraceAsArray", "false"));
}

private static StringBuilder getStringBuilder() {
StringBuilder result = STRING_BUILDER.get();
if (result == null) {
result = new StringBuilder(1024);
STRING_BUILDER.set(result);
}

result.setLength(0);

return result;
}

@Override
public String format(ExtLogRecord record) {
StringBuilder builder = new StringBuilder();
StringBuilder builder = getStringBuilder();
EcsJsonSerializer.serializeObjectStart(builder, record.getMillis());
EcsJsonSerializer.serializeLogLevel(builder, record.getLevel().getName());
EcsJsonSerializer.serializeFormattedMessage(builder, record.getFormattedMessage());
Expand Down