Skip to content

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Oct 27, 2025

I used this as an opportunity to use 3.13 everywhere I could.

@prodsecmachine
Copy link

prodsecmachine commented Oct 27, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

noxfile.py Outdated
args = []
if pandas_version[0] == "1":
args.append("numpy<2")
if session.name == "3.13" and pandas_version == "1.5.3":
Copy link
Contributor

@miguelgrinberg miguelgrinberg Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest a proper >= 3.13 version check here, because if not this conditional will have to be revised once we add support for 3.14.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed in #810 (2cc7cb0c1). This allowed me to see that my code wasn't working, but we didn't see it as CI never tried to run Python 3.13 and Pandas 1.5. It does work now:

❯ nox -rs test-3.13
nox > Running session test-3.13(pandas_version='1.5.3')
nox > Re-using existing virtual environment at .nox/test-3-13-pandas_version-1-5-3.
nox > Session test-3.13(pandas_version='1.5.3') skipped: Pandas 1.5 does not support Python 3.13.
nox > Running session test-3.13(pandas_version='2.3.3')
nox > Re-using existing virtual environment at .nox/test-3-13-pandas_version-2-3-3.
nox > python -m pip install -r requirements-dev.txt 'pandas~=2.3.3'
^Cnox > Interrupted...
nox > Session test-3.13(pandas_version='2.3.3') interrupted.

@pquentin pquentin merged commit 2cb9a98 into elastic:main Oct 29, 2025
10 checks passed
This was referenced Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants