-
Notifications
You must be signed in to change notification settings - Fork 110
Drop Python 3.9, support Python 3.13 #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
noxfile.py
Outdated
| args = [] | ||
| if pandas_version[0] == "1": | ||
| args.append("numpy<2") | ||
| if session.name == "3.13" and pandas_version == "1.5.3": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest a proper >= 3.13 version check here, because if not this conditional will have to be revised once we add support for 3.14.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed in #810 (2cc7cb0c1). This allowed me to see that my code wasn't working, but we didn't see it as CI never tried to run Python 3.13 and Pandas 1.5. It does work now:
❯ nox -rs test-3.13
nox > Running session test-3.13(pandas_version='1.5.3')
nox > Re-using existing virtual environment at .nox/test-3-13-pandas_version-1-5-3.
nox > Session test-3.13(pandas_version='1.5.3') skipped: Pandas 1.5 does not support Python 3.13.
nox > Running session test-3.13(pandas_version='2.3.3')
nox > Re-using existing virtual environment at .nox/test-3-13-pandas_version-2-3-3.
nox > python -m pip install -r requirements-dev.txt 'pandas~=2.3.3'
^Cnox > Interrupted...
nox > Session test-3.13(pandas_version='2.3.3') interrupted.
I used this as an opportunity to use 3.13 everywhere I could.