Skip to content

[otel] Add back elastictrace processor #10588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Oct 15, 2025
Merged

[otel] Add back elastictrace processor #10588

merged 10 commits into from
Oct 15, 2025

Conversation

@gregkalapos
Copy link
Contributor

@gregkalapos gregkalapos commented Oct 15, 2025 •
edited
Loading

What does this PR do?

This PR adds back the elastictrace processor to the EDOT collector and bumps the version to v0.12.0.

This version is marked as deprecated (in favor of the elasticapm processor) and just wraps the elasticapm processor itself.

Why is it important?

This way, we don't break users. The elastictrace processor is marked as a core component and we don't want to just remove it. Therefore, we'll keep one around for existing users, so they can gradually move to the elasticapm processor.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (in prior PRs)
  • I have made corresponding change to the default configuration files (in prior PRs)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • [ ]I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@gregkalapos gregkalapos added the enhancement New feature or request label Oct 15, 2025
@gregkalapos gregkalapos self-assigned this Oct 15, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 15, 2025

This pull request does not have a backport label. Could you fix it @gregkalapos? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

gregkalapos
gregkalapos commented Oct 15, 2025
View reviewed changes
@gregkalapos gregkalapos marked this pull request as ready for review October 15, 2025 14:44
@gregkalapos gregkalapos requested review from a team as code owners October 15, 2025 14:44
@theletterf
Copy link
Contributor

theletterf commented Oct 15, 2025 •
edited
Loading

@gregkalapos Could you also add it to the deprecated-components.yaml file? It's a new mechanism we've introduced to mark components that are going to be deprecated. It should be fine to leave it in both files, I think, though I'll try on your branch once you've added it. +CC @AlexanderWert

I think we should also backport this change to the 9.2 branch.

@pierrehilbert pierrehilbert added backport-9.2 Automated backport to the 9.2 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Oct 15, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

pierrehilbert
pierrehilbert previously approved these changes Oct 15, 2025
View reviewed changes
@gregkalapos
Copy link
Contributor Author

We'd need another approve from @elastic/ingest-otel-leads.

@gregkalapos
Copy link
Contributor Author

@gregkalapos Could you also add it to the deprecated-components.yaml file? It's a new mechanism we've introduced to mark components that are going to be deprecated. It should be fine to leave it in both files, I think, though I'll try on your branch once you've added it. +CC @AlexanderWert

I think we should also backport this change to the 9.2 branch.

I added it.

@gregkalapos gregkalapos enabled auto-merge (squash) October 15, 2025 17:24
@gregkalapos gregkalapos merged commit 7a4b56c into elastic:main Oct 15, 2025
21 checks passed
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @gregkalapos

mergify bot pushed a commit that referenced this pull request Oct 15, 2025
@gregkalapos @mergify
[otel] Add back elastictrace processor (#10588)
3d3236f 
* [otel] Add back elastictrace processor

* bump elasticapm processor version

This version adds a public function used by the elastictrace processor

* Create 1760538256-add_back_elastictrace_processor.yaml

* Update go.mod

* Update go.sum

* Update notice files

* Update readme and testdata files

* Update deprecated-components.yaml

(cherry picked from commit 7a4b56c)
@mergify mergify bot mentioned this pull request Oct 15, 2025
Merged
7 tasks
cmacknz pushed a commit that referenced this pull request Oct 16, 2025
@mergify @gregkalapos
[otel] Add back elastictrace processor (#10588) (#10609)
3166ffc 
* [otel] Add back elastictrace processor

* bump elasticapm processor version

This version adds a public function used by the elastictrace processor

* Create 1760538256-add_back_elastictrace_processor.yaml

* Update go.mod

* Update go.sum

* Update notice files

* Update readme and testdata files

* Update deprecated-components.yaml

(cherry picked from commit 7a4b56c)

Co-authored-by: Gergely Kalapos <gergo@kalapos.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierrehilbert pierrehilbert pierrehilbert approved these changes

@theletterf theletterf theletterf approved these changes

@swiatekm swiatekm Awaiting requested review from swiatekm swiatekm is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@gregkalapos gregkalapos

Labels

backport-9.2 Automated backport to the 9.2 branch enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gregkalapos @theletterf @elasticmachine @pierrehilbert