-
Notifications
You must be signed in to change notification settings - Fork 203
Fix cleanup manual rollback #11236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cleanup manual rollback #11236
Conversation
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
|
|
This pull request is now in conflicts. Could you fix it? 🙏 |
af2a6d5 to
174f2e4
Compare
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
💛 Build succeeded, but was flaky
Failed CI StepsHistory
cc @pchila |
What does this PR do?
This PR fixes the relative path calculation for agent versioned homes to preserve introduced with #9643.
Removes ambiguity in what a path to a versioned home to preserve should look like: it should always be
data/elastic-agent-<variable unique version part here>.Adds a few checks and resolves the relative path when calling rollback from command line.
Why is it important?
To preserve elastic-agent versioned home directories correctly during cleanup.
Checklist
./changelog/fragmentsusing the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself