Merged
Conversation
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (27)
💤 Files with no reviewable changes (19)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThis PR replaces the in-repo OpAMP implementation with the upstream package 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/distro/test_distro.py`:
- Around line 555-557: Update every test expectation that calls
client.update_effective_config in this test class to include the new keyword
argument content_type="application/json" because EDOTOpAMPCallbacks.on_message()
now passes that kwarg; locate calls to client.update_effective_config (the
assertion lines shown) and add the content_type kwarg to the
assert_called_once_with(...) expectation so the expected call signature matches
the implementation.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 0b8102e1-7c7c-4a7c-893a-ad27319aee25
📒 Files selected for processing (27)
dev-requirements.txtopamp-gen-requirements.txtpyproject.tomlscripts/opamp_proto_codegen.shsrc/elasticotel/distro/__init__.pysrc/elasticotel/distro/config.pysrc/opentelemetry/_opamp/README.mdsrc/opentelemetry/_opamp/__init__.pysrc/opentelemetry/_opamp/agent.pysrc/opentelemetry/_opamp/client.pysrc/opentelemetry/_opamp/exceptions.pysrc/opentelemetry/_opamp/messages.pysrc/opentelemetry/_opamp/proto/anyvalue_pb2.pysrc/opentelemetry/_opamp/proto/anyvalue_pb2.pyisrc/opentelemetry/_opamp/proto/opamp_pb2.pysrc/opentelemetry/_opamp/proto/opamp_pb2.pyisrc/opentelemetry/_opamp/transport/base.pysrc/opentelemetry/_opamp/transport/exceptions.pysrc/opentelemetry/_opamp/transport/requests.pysrc/opentelemetry/_opamp/version.pytests/distro/test_distro.pytests/opamp/cassettes/test_connection_remote_config_status_heartbeat_disconnection.yamltests/opamp/cassettes/test_default_callbacks.yamltests/opamp/test_agent.pytests/opamp/test_client.pytests/opamp/test_e2e.pytests/opamp/transport/test_requests.py
💤 Files with no reviewable changes (19)
- src/opentelemetry/_opamp/README.md
- src/opentelemetry/_opamp/exceptions.py
- src/opentelemetry/_opamp/init.py
- opamp-gen-requirements.txt
- src/opentelemetry/_opamp/transport/exceptions.py
- src/opentelemetry/_opamp/proto/anyvalue_pb2.py
- src/opentelemetry/_opamp/transport/requests.py
- scripts/opamp_proto_codegen.sh
- src/opentelemetry/_opamp/transport/base.py
- src/opentelemetry/_opamp/client.py
- src/opentelemetry/_opamp/proto/opamp_pb2.py
- src/opentelemetry/_opamp/proto/anyvalue_pb2.pyi
- tests/opamp/test_client.py
- tests/opamp/test_agent.py
- src/opentelemetry/_opamp/agent.py
- src/opentelemetry/_opamp/proto/opamp_pb2.pyi
- src/opentelemetry/_opamp/version.py
- src/opentelemetry/_opamp/messages.py
- tests/opamp/transport/test_requests.py
Delete our version of the client and updates the distro code for the upstream changes regarding naming and client callbacks. This keeps a bunch of e2e tests against our own server implementation.
xrmx
force-pushed
the
use-upstream-opamp-client
branch
from
f7f6803 to
381974a
Compare
trentm
approved these changes
Mar 26, 2026
theletterf
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Delete our version of the client and updates the distro code for the upstream changes regarding naming and client callbacks. This keeps a bunch of e2e tests against our own server implementation.
Related issues
Closes #508