Skip to content

distro: handle opentelemetry-instrumentation-logging LoggingHandler as the sdk one#552

Open
xrmx wants to merge 2 commits into
mainfrom
handle-logging-handler
Open

distro: handle opentelemetry-instrumentation-logging LoggingHandler as the sdk one#552
xrmx wants to merge 2 commits into
mainfrom
handle-logging-handler

Conversation

@xrmx
Copy link
Copy Markdown
Member

@xrmx xrmx commented May 21, 2026

What does this pull request do?

With recent releases the opentelemetry-instrumentation-logging LoggingHandler is used if installed and so we need to consider that as well when deciding to propagate.

Related issues

Closes #551

…s the sdk one

With recent releases the opentelemetry-instrumentation-logging
LoggingHandler is used if installed and so we need to consider that as
well when deciding to propagate.
@xrmx xrmx requested a review from a team as a code owner May 21, 2026 09:52
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

Warning

Rate limit exceeded

@xrmx has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 5 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: cb7575ad-31a6-4110-a11b-d3463667e3a0

📥 Commits

Reviewing files that changed from the base of the PR and between 4a8805e and 8c4457c.

📒 Files selected for processing (1)
  • src/elasticotel/distro/config.py
📝 Walkthrough

Walkthrough

This PR adds conditional import handling and fallback logic for LoggingHandler to support both the instrumentation package and SDK implementations. The config.py propagate determination now checks for both handler types. Test coverage is expanded with a new test for the SDK handler scenario and skipIf guards for the instrumentation-dependent test. Development dependencies are updated (certifi, wrapt, opentelemetry-instrumentation-logging) and pyproject.toml dev dependencies are reformatted from single-line to multi-line structure.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The PR implements the required logging propagation logic to recognize LoggingHandler from both opentelemetry-instrumentation-logging and the deprecated SDK.
Out of Scope Changes check ✅ Passed All changes directly address the linked issue. Dependency updates and test adjustments support the core logging handler logic changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch handle-logging-handler
  • 🛠️ Update Documentation

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

xrmx added a commit that referenced this pull request May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle opentelemetry-instrumentation-logging LoggingHandler

2 participants