Skip to content

Conversation

@jsoriano
Copy link
Member

@jsoriano jsoriano commented Nov 9, 2022

No description provided.

@jsoriano jsoriano requested a review from a team November 9, 2022 14:47
@jsoriano jsoriano self-assigned this Nov 9, 2022
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

When should this https://github.com/elastic/integrations/blob/main/.ci/schedule-daily.groovy#L38-L42 be updated to 8.6.0-SNAPSHOT version?

@jsoriano
Copy link
Member Author

jsoriano commented Nov 9, 2022

When should this https://github.com/elastic/integrations/blob/main/.ci/schedule-daily.groovy#L38-L42 be updated to 8.6.0-SNAPSHOT version?

Let's update it in this PR too 🙂

@jsoriano
Copy link
Member Author

jsoriano commented Nov 9, 2022

When should this https://github.com/elastic/integrations/blob/main/.ci/schedule-daily.groovy#L38-L42 be updated to 8.6.0-SNAPSHOT version?

Let's update it in this PR too slightly_smiling_face

I mean, after we update integrations with this PR 😄

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 9, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-17T14:19:01.043+0000

  • Duration: 29 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 863
Skipped 0
Total 863

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 9, 2022

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (35/35) 💚
Files 66.923% (87/130) 👍
Classes 61.622% (114/185) 👍
Methods 47.865% (370/773) 👍
Lines 30.726% (3319/10802) 👍
Conditionals 100.0% (0/0) 💚

@jsoriano
Copy link
Member Author

jsoriano commented Nov 9, 2022

Looks like something has changed in the floats format, I will take a look.

@jsoriano jsoriano marked this pull request as draft November 9, 2022 15:58
{
"example": {
"float": 6.9200717685635164E18,
"float": 6.920071768563516E18,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that something has changed on parsing of big numbers in Elasticsearch 8.5.0, let's hope this doesn't affect the tests of many integrations 🤞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported in elastic/elasticsearch#91563 just in case.

@jsoriano jsoriano marked this pull request as ready for review November 14, 2022 19:19
"example": {
"float": 1.624617166182E9,
"float_as_long": 1.62461722E9
"float_as_long": 1.6246172E9
Copy link
Member Author

@jsoriano jsoriano Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this number is originally 1624617166.182, and processed with:

  - convert:
    field: message
    target_field: example.float_as_long
    type: float

{
"example": {
"float": 6.9200717685635164E18,
"float": 6.920071768563516E18,
Copy link
Member Author

@jsoriano jsoriano Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this number is originally 6920071768563516847, and processed with:

  - convert:
    field: message
    target_field: example.float
    type: double

@jsoriano
Copy link
Member Author

/test

@jsoriano
Copy link
Member Author

/test

@jsoriano jsoriano merged commit ee6c250 into elastic:main Nov 17, 2022
@jsoriano jsoriano deleted the stack-version-8.5.0 branch November 17, 2022 14:56
@jsoriano jsoriano mentioned this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants