-
Notifications
You must be signed in to change notification settings - Fork 127
Bump up default Elastic stack version to v8.5.0 #1033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
When should this https://github.com/elastic/integrations/blob/main/.ci/schedule-daily.groovy#L38-L42 be updated to 8.6.0-SNAPSHOT version?
Let's update it in this PR too 🙂 |
I mean, after we update integrations with this PR 😄 |
🌐 Coverage report
|
|
Looks like something has changed in the floats format, I will take a look. |
| { | ||
| "example": { | ||
| "float": 6.9200717685635164E18, | ||
| "float": 6.920071768563516E18, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that something has changed on parsing of big numbers in Elasticsearch 8.5.0, let's hope this doesn't affect the tests of many integrations 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reported in elastic/elasticsearch#91563 just in case.
| "example": { | ||
| "float": 1.624617166182E9, | ||
| "float_as_long": 1.62461722E9 | ||
| "float_as_long": 1.6246172E9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, this number is originally 1624617166.182, and processed with:
- convert:
field: message
target_field: example.float_as_long
type: float
| { | ||
| "example": { | ||
| "float": 6.9200717685635164E18, | ||
| "float": 6.920071768563516E18, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FTR, this number is originally 6920071768563516847, and processed with:
- convert:
field: message
target_field: example.float
type: double
|
/test |
|
/test |
No description provided.