Skip to content

Bump up default Elastic stack version to v8.5.0 #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Bump up default Elastic stack version to v8.5.0 #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a23e55b
Bump up default Elastic stack version to v8.5.0
jsoriano Nov 9, 2022
9d05c2b
Fix number format
jsoriano Nov 14, 2022
0ea9e79
Merge remote-tracking branch 'origin/main' into stack-version-8.5.0
jsoriano Nov 17, 2022
f8c06be
Fix format
jsoriano Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/install/stack_version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@ package install

const (
// DefaultStackVersion is the default version of the stack
DefaultStackVersion = "8.4.1"
DefaultStackVersion = "8.5.0"
)
4 changes: 2 additions & 2 deletions ...ther/number_formats/data_stream/numbers/_dev/test/pipeline/test-example.log-expected.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
},
{
"example": {
"float": 6.9200717685635164E18,
"float": 6.920071768563516E18,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that something has changed on parsing of big numbers in Elasticsearch 8.5.0, let's hope this doesn't affect the tests of many integrations 🤞

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported in elastic/elasticsearch#91563 just in case.

Copy link
Member Author

@jsoriano jsoriano Nov 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this number is originally 6920071768563516847, and processed with:

  - convert:
    field: message
    target_field: example.float
    type: double

"float_as_long": 6.9200716E18,
"long": 6920071768563516847,
"long_as_float": 6920071768563516847
Expand All @@ -67,7 +67,7 @@
{
"example": {
"float": 1.624617166182E9,
"float_as_long": 1.62461722E9
"float_as_long": 1.6246172E9
Copy link
Member Author

@jsoriano jsoriano Nov 14, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR, this number is originally 1624617166.182, and processed with:

  - convert:
    field: message
    target_field: example.float_as_long
    type: float

},
"message": "1624617166.182"
}
Expand Down