Update conditional for release step #1159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
mrodm
commented
Feb 23, 2023
Comment on lines
+46
to
+49
| stage('Check if the PR contains Buildkite pipeline') { | ||
| when { | ||
| changeRequest() | ||
| } |
There was a problem hiding this comment.
This stage is intended to check if the PRs are "old", it means if they are based on a commit previous to the buildkite pipeline.
I think it could be just run in case of PRs (changeRequest()). The last run when a tag was pushed failed https://fleet-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Felastic-package/detail/v0.75.0/1/pipeline/
jsoriano
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the filtering in the release step since in the latest attempt to push a tag, that step was not executed.
It looks like build.branch is set to the same value as the tag. At least this is what the environment variables show:
The condition now is just the value of the
build.tag.