Skip to content

Update conditional for release step #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023
Merged

Update conditional for release step #1159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6fb66e
Update conditional for release step
mrodm Feb 23, 2023
afe1ad2
Just run stage in PRs
mrodm Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .buildkite/pipeline.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ steps:
key: "release"
# build.tag != null && build.branch == "main"
if: |
build.tag =~ /^v[0-9]+[.][0-9]+[.][0-9]+$$/ && build.branch == "main"
build.tag =~ /^v[0-9]+[.][0-9]+[.][0-9]+$$/
command: ".buildkite/scripts/release.sh"
agents:
image: "golang:1.19.5"
Expand Down
8 changes: 4 additions & 4 deletions .ci/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,10 @@ pipeline {
stash allowEmpty: true, name: 'source', useDefaultExcludes: false
}
}
/**
Check the source code.
*/
stage('Check it contains Buildkite pipeline') {
stage('Check if the PR contains Buildkite pipeline') {
when {
changeRequest()
}
Comment on lines +46 to +49
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This stage is intended to check if the PRs are "old", it means if they are based on a commit previous to the buildkite pipeline.

I think it could be just run in case of PRs (changeRequest()). The last run when a tag was pushed failed https://fleet-ci.elastic.co/blue/organizations/jenkins/Ingest-manager%2Felastic-package/detail/v0.75.0/1/pipeline/

steps {
cleanup()
dir("${BASE_DIR}"){
Expand Down