-
Notifications
You must be signed in to change notification settings - Fork 127
Update pipeline to test with integrations #1277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
25749c0 to
0fc616d
Compare
|
buildkite test integrations |
|
test integrations |
|
test integrations |
|
test integrations |
|
buildkite test integrations |
|
buildkite test integrations |
|
test integrations |
|
test integrations |
|
test integrations |
|
test integrations |
|
test integrations |
|
buildkite test integrations |
|
buildkite test integrations |
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313 |
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313 |
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313 |
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313 |
| - label: ":hammer: Create PR in integrations" | ||
| key: pr-integrations | ||
| command: ".buildkite/scripts/test-with-integrations.sh" | ||
| agents: | ||
| provider: "gcp" | ||
| depends_on: | ||
| - check-static | ||
| - unit-tests-linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added these steps to avoid triggering a new CI job for integrations repo (that lasts 2 hours) if it has some failures.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! 🚀 I wonder if there would be a way to report the result back to this PR.
| create_integrations_pull_request() { | ||
| # requires GITHUB_TOKEN | ||
| local temp_path=$(mktemp -d -p ${WORKSPACE} -t ${TMP_FOLDER_TEMPLATE}) | ||
| echo "Creating Pull Request" | ||
| message="Update ${GITHUB_PR_BASE_REPO} reference to $(get_source_commit_link).\nAutomated by [Buildkite build](${BUILDKITE_BUILD_URL})\n\nRelates: $(get_source_pr_link)" | ||
| echo -e $message > ${temp_path}/body-pr.txt | ||
| retry 3 \ | ||
| gh pr create \ | ||
| --title "${INTEGRATIONS_PR_TITLE}" \ | ||
| --body-file ${temp_path}/body-pr.txt \ | ||
| --draft \ | ||
| --base ${INTEGRATIONS_SOURCE_BRANCH} \ | ||
| --head ${INTEGRATIONS_PR_BRANCH} \ | ||
| --assignee ${GITHUB_PR_HEAD_USER} | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of creating a pull request, would it be possible to trigger an integrations build, parameterized with the version of elastic-package, and report the status on the elastic-package PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be adding more logic to the integrations job.
An advantage of creating that pull request is that everything is tracked in one place, and it can be seen the evolution.
|
/test |
💚 Build Succeeded
History
cc @mrodm |
This PR adds step to create a Pull Request in integrations updating the elastic-package version used.
This pipeline should be just triggered by adding a comment in the PR.