Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented May 23, 2023

This PR adds step to create a Pull Request in integrations updating the elastic-package version used.

This pipeline should be just triggered by adding a comment in the PR.

@mrodm mrodm self-assigned this May 23, 2023
@mrodm mrodm force-pushed the update_pipeline_integrations branch from 25749c0 to 0fc616d Compare May 23, 2023 15:56
@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

buildkite test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

buildkite test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 23, 2023

buildkite test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

buildkite test integrations

@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

buildkite test integrations

@mrodm mrodm closed this May 24, 2023
@mrodm mrodm deleted the update_pipeline_integrations branch May 24, 2023 18:02
@mrodm mrodm restored the update_pipeline_integrations branch May 24, 2023 18:03
@mrodm mrodm reopened this May 24, 2023
@mrodm
Copy link
Contributor Author

mrodm commented May 24, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313

@mrodm mrodm marked this pull request as ready for review May 25, 2023 09:54
@mrodm mrodm requested review from a team and alexsapran May 25, 2023 09:54
@mrodm
Copy link
Contributor Author

mrodm commented May 25, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313

@mrodm
Copy link
Contributor Author

mrodm commented May 25, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313

@mrodm
Copy link
Contributor Author

mrodm commented May 25, 2023

test integrations

@elasticmachine
Copy link
Collaborator

Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#6313

Comment on lines +25 to +32
- label: ":hammer: Create PR in integrations"
key: pr-integrations
command: ".buildkite/scripts/test-with-integrations.sh"
agents:
provider: "gcp"
depends_on:
- check-static
- unit-tests-linux
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added these steps to avoid triggering a new CI job for integrations repo (that lasts 2 hours) if it has some failures.

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! 🚀 I wonder if there would be a way to report the result back to this PR.

Comment on lines +73 to +87
create_integrations_pull_request() {
# requires GITHUB_TOKEN
local temp_path=$(mktemp -d -p ${WORKSPACE} -t ${TMP_FOLDER_TEMPLATE})
echo "Creating Pull Request"
message="Update ${GITHUB_PR_BASE_REPO} reference to $(get_source_commit_link).\nAutomated by [Buildkite build](${BUILDKITE_BUILD_URL})\n\nRelates: $(get_source_pr_link)"
echo -e $message > ${temp_path}/body-pr.txt
retry 3 \
gh pr create \
--title "${INTEGRATIONS_PR_TITLE}" \
--body-file ${temp_path}/body-pr.txt \
--draft \
--base ${INTEGRATIONS_SOURCE_BRANCH} \
--head ${INTEGRATIONS_PR_BRANCH} \
--assignee ${GITHUB_PR_HEAD_USER}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of creating a pull request, would it be possible to trigger an integrations build, parameterized with the version of elastic-package, and report the status on the elastic-package PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be adding more logic to the integrations job.
An advantage of creating that pull request is that everything is tracked in one place, and it can be seen the evolution.

@mrodm mrodm changed the title Update pipeline integrations Update pipeline to test with integrations Jun 1, 2023
@mrodm
Copy link
Contributor Author

mrodm commented Jun 1, 2023

/test

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @mrodm

@mrodm mrodm merged commit de20b6d into elastic:main Jun 1, 2023
@mrodm mrodm deleted the update_pipeline_integrations branch June 1, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants