Add information about test integrations automation #1351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
commented
Jul 11, 2023
| Elasticsearch in stacks managed by elastic-package. It is recommended to use | ||
| an absolute path, out of the `.elastic-package` directory. | ||
|
|
||
| ## Development |
There was a problem hiding this comment.
This section was duplicated. Merged into the other Development section in line 39
mrodm
commented
Jul 11, 2023
Comment on lines
+44
to
+58
| `make build` - build the tool source | ||
|
|
||
| `make clean` - delete elastic-package binary and build folder | ||
|
|
||
| `make format` - format the Go code | ||
|
|
||
| `make check` - one-liner, used by CI to verify if source code is ready to be pushed to the repository | ||
|
|
||
| `make install` - build the tool source and move binary to `$GOBIN` | ||
|
|
||
| `make gomod` - ensure go.mod and go.sum are up to date | ||
|
|
||
| `make update` - update README.md file | ||
|
|
||
| `make licenser` - add the Elastic license header in the source code |
There was a problem hiding this comment.
Added a few more targets, and change make vendor target by the make gomod one.
jlind23
approved these changes
Jul 11, 2023
|
/test |
jsoriano
approved these changes
Jul 12, 2023
tools/readme/readme.md.tmpl
Outdated
Comment on lines
106
to
108
| This process can also be done automatically directly from your Pull Request by adding a comment `test integrations`. Example: | ||
| - Comment: https://github.com/elastic/elastic-package/pull/1335#issuecomment-1619721861 | ||
| - Pull Request created in integrations repository: https://github.com/elastic/integrations/pull/6756 |
There was a problem hiding this comment.
Perhaps we should mention this first, before the detailed steps.
💚 Build Succeeded
History
cc @mrodm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new section in the README to include the information about the
test integrationsautomation.This PR also merges the two Development sections that were available in the README.
Rendered README can be checked here.
Follow-up #1277