Validate JSON output file before unmarshall #1298
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test |
bhapas
changed the title
|
/test |
mrodm
reviewed
Jun 8, 2023
internal/testrunner/runners/system/servicedeployer/terraform.go
Outdated
Show resolved
Hide resolved
bhapas
changed the title
mrodm
reviewed
Jun 8, 2023
internal/testrunner/runners/system/servicedeployer/terraform_test.go
Outdated
Show resolved
Hide resolved
Comment on lines
+68
to
+71
| if !json.Valid(content) { | ||
| logger.Debug("Invalid Json content in the terraform output file, skipped creating outputs") | ||
| return nil | ||
| } |
There was a problem hiding this comment.
What happens if aws_logs has an invalid json here? Would the test package fail if that happens ?
There was a problem hiding this comment.
The system test fails on the package if there is an invalid json because the output is not available in the system test config
💚 Build Succeeded
History
cc @bhapas |
mrodm
approved these changes
Jun 8, 2023
mrodm
added a commit
to mrodm/elastic-package
that referenced
this pull request
Jun 8, 2023
This reverts commit 5ad8bd8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The terraform output file sometimes is empty and json unmarshall throws an error.
The fix is to validate the json file before unmarshalling it.