Terraform outputs in aws package make the test flaky

[bhapas]

The terraform outputs in aws package as added here have flaky tests on CI.

The outputs are not generated sometimes and it results in the flaky test

Sample logs:

2023/06/08 11:43:57 DEBUG Unmarshalling terraform output json
2023/06/08 11:43:57 DEBUG **********JSON CONTENT**************** {
  "instance_id": {
    "sensitive": false,
    "type": "string",
    "value": "i-somerandomid"
  }
}

2023/06/08 12:22:06 DEBUG Unmarshalling terraform output json
2023/06/08 12:22:06 DEBUG **********JSON CONTENT****************
2023/06/08 12:22:06 DEBUG waiting for 1s before tearing down...
Error: error running package system tests: could not complete test run: could not setup service: could not handle terraform output error during json Unmarshal unexpected end of JSON input
+ cleanup
+ r=1

[bhapas]

The issue is that the script running terraform service deployer does a health check to see if the file /tmp/tf_applied is created , which was the last step in the script.

When terraform outputs are generated the command was added at the end resulting in exiting the process execution before terraform outputs are generated [ Intermittent ]. #1301 should fix this