Skip to content

Conversation

@mrodm
Copy link
Contributor

@mrodm mrodm commented Aug 28, 2023

Fixes #942

This PR ensures that sub-commands from elastic-package stack do not accept positional arguments.

Example:

 $ elastic-package stack up -v -d --version 8.9.0 --services package-registry elasticsearch
Error: unknown command "elasticsearch" for "elastic-package stack up"

 $ elastic-package stack up -v -d --version 8.9.0 --services package-registry,elasticsearch
2023/08/28 16:28:10 DEBUG Enable verbose logging
2023/08/28 16:28:10 DEBUG Distribution built without a version tag, can't determine release chronology. Please consider using official releases at https://github.com/elastic/elastic-package/releases
Boot up the Elastic stack
...

@mrodm mrodm marked this pull request as ready for review August 28, 2023 14:49
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@mrodm mrodm merged commit 8f773ee into elastic:main Aug 28, 2023
@mrodm mrodm deleted the review_commands_stack branch August 28, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Explicitly fail when there are unexpected arguments

3 participants