Skip to content

Ensure no positional args are set in stack command #1412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Ensure no positional args are set in stack command #1412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions cmd/stack.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ func setupStackCommand() *cobraext.Command {
Use: "up",
Short: "Boot up the stack",
Long: stackUpLongDescription,
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
cmd.Println("Boot up the Elastic stack")

Expand Down Expand Up @@ -112,6 +113,7 @@ func setupStackCommand() *cobraext.Command {
downCommand := &cobra.Command{
Use: "down",
Short: "Take down the stack",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
cmd.Println("Take down the Elastic stack")

Expand Down Expand Up @@ -141,6 +143,7 @@ func setupStackCommand() *cobraext.Command {
updateCommand := &cobra.Command{
Use: "update",
Short: "Update the stack to the most recent versions",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
cmd.Println("Update the Elastic stack")

Expand Down Expand Up @@ -177,6 +180,7 @@ func setupStackCommand() *cobraext.Command {
shellInitCommand := &cobra.Command{
Use: "shellinit",
Short: "Export environment variables",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
shellName, err := cmd.Flags().GetString(cobraext.ShellInitShellFlagName)
if err != nil {
Expand Down Expand Up @@ -206,6 +210,7 @@ func setupStackCommand() *cobraext.Command {
dumpCommand := &cobra.Command{
Use: "dump",
Short: "Dump stack data for debug purposes",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
output, err := cmd.Flags().GetString(cobraext.StackDumpOutputFlagName)
if err != nil {
Expand Down Expand Up @@ -241,6 +246,7 @@ func setupStackCommand() *cobraext.Command {
statusCommand := &cobra.Command{
Use: "status",
Short: "Show status of the stack services",
Args: cobra.NoArgs,
RunE: func(cmd *cobra.Command, args []string) error {
profile, err := cobraext.GetProfileFlag(cmd)
if err != nil {
Expand Down