-
Notifications
You must be signed in to change notification settings - Fork 127
[cleanup] Fix creation date tag for buckets #1742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # It looks like tags are not reported by cloud-reaper for buckets | ||
| # - type: "regex" | ||
| # pointer: "/extra/tags/repo" | ||
| # param: "^(elastic-package|integrations)" | ||
| # - type: "=" | ||
| # pointer: "/extra/tags/environment" | ||
| # param: "ci" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some doubts for these tags in Storage Bucket resources.
@amannocci , are tags also reported/used by cloud-reaper to filter resources ?
At least it looks like that in the verbose output other tags a part from creation_date are not shown:
ObjectStorageBucket(
name=xxx
extra={'creation_date': '2024-03-26T06:57:28.000Z'}
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested adding this filter to force showing some queues:
- type: "regex"
pointer: "/extra/tags/repo"
param: "^(elastic-package|integrations|beats)" but, cloud-reaper does not report anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Talked offline to @amannocci , and currently this is the expected behavior. cloud-reaper needs to make an additional API call to get all the tags set in Buckets.
Leaving the filters commented until this support is added into cloud-reaper.
| filters: | ||
| - type: "<" | ||
| pointer: "/created_at" | ||
| pointer: "/extra/creation_date" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creation date is not set in the same field as other resources. Updated to the right field.
💚 Build Succeeded
cc @mrodm |
Set the right field to check for creation date in Storage Bucket resources.