Skip to content

[cleanup] Fix creation date tag for buckets #1742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2024
Merged

[cleanup] Fix creation date tag for buckets #1742

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .buildkite/configs/cleanup.aws.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,18 @@ scanners:
- us-east-1
filters:
- type: "<"
pointer: "/created_at"
pointer: "/extra/creation_date"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creation date is not set in the same field as other resources. Updated to the right field.

param: "${CREATION_DATE}"
converters:
param: "date"
value: "date"
- type: "regex"
pointer: "/extra/tags/repo"
param: "^(elastic-package|integrations)"
- type: "="
pointer: "/extra/tags/environment"
param: "ci"
# It looks like tags are not reported by cloud-reaper for buckets
# - type: "regex"
# pointer: "/extra/tags/repo"
# param: "^(elastic-package|integrations)"
# - type: "="
# pointer: "/extra/tags/environment"
# param: "ci"
Comment on lines +48 to +54
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some doubts for these tags in Storage Bucket resources.
@amannocci , are tags also reported/used by cloud-reaper to filter resources ?

At least it looks like that in the verbose output other tags a part from creation_date are not shown:

ObjectStorageBucket(
  name=xxx
  extra={'creation_date': '2024-03-26T06:57:28.000Z'}
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested adding this filter to force showing some queues:

          - type: "regex"
            pointer: "/extra/tags/repo"
            param: "^(elastic-package|integrations|beats)"

but, cloud-reaper does not report anything

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talked offline to @amannocci , and currently this is the expected behavior. cloud-reaper needs to make an additional API call to get all the tags set in Buckets.

Leaving the filters commented until this support is added into cloud-reaper.

- type: "regex"
pointer: "/name"
param: "^elastic-package-(.*)"
Expand Down