Fix goreleaser: populate ldflags #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
reviewed
Jul 16, 2021
| builds: | ||
| - ldflags: | ||
| - -X github.com/elastic/elastic-package/internal/version.CommitHash={{.ShortCommit}} | ||
| - -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}} No newline at end of file |
There was a problem hiding this comment.
Users are going to be probably more interested about the version itself 🙂 Add the tag to the output of elastic-package version too, so it displays something like this?
$ goreleaser build --skip-validate --single-target
$ ./dist/elastic-package_darwin_amd64/elastic-package version
elastic-package has been installed.
elastic-package v0.9.1 version-hash e59a09c (build time: 2021-07-16T13:11:19+02:00)
Suggested change
| - -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}} | |
| - -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}} | |
| - -X github.com/elastic/elastic-package/internal/version.Tag={{.Tag}} |
There was a problem hiding this comment.
I want to do this in the next follow-up (just after this one :) ) as it requires a bit of coding. With this PR I want to fix first what's still broken.
If you prefer I can try to modify version's logic in this PR (both options work for me).
jsoriano
approved these changes
Jul 16, 2021
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes missing build info while user runs
elastic-package version.Issue: #32
Tested:
@jsoriano Thank you for suggestions in #431 (comment) . I suggest to review and merge this PR, and then we can review the entire working solution in terms of further adjustments. This distribution method is not advertised yet, so we can disable it if we decide it doesn't meet our requirements.