Skip to content

Fix goreleaser: populate ldflags #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix goreleaser: populate ldflags #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .goreleaser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
builds:
- ldflags:
- -X github.com/elastic/elastic-package/internal/version.CommitHash={{.ShortCommit}}
- -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users are going to be probably more interested about the version itself 🙂 Add the tag to the output of elastic-package version too, so it displays something like this?

$ goreleaser build --skip-validate --single-target
$ ./dist/elastic-package_darwin_amd64/elastic-package version
elastic-package has been installed.
elastic-package v0.9.1 version-hash e59a09c (build time: 2021-07-16T13:11:19+02:00)
Suggested change
- -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}}
- -X github.com/elastic/elastic-package/internal/version.BuildTime={{.Timestamp}}
- -X github.com/elastic/elastic-package/internal/version.Tag={{.Tag}}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to do this in the next follow-up (just after this one :) ) as it requires a bit of coding. With this PR I want to fix first what's still broken.

If you prefer I can try to modify version's logic in this PR (both options work for me).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM to do it in a follow up.