Improve code quality based on linter hints #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to remove magic constants, handle errors and clean up. Some changes requested by opinionated editor/linter. Makefile fixed to ensure that build directory exists before starting work.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
mtojek
reviewed
Nov 2, 2021
internal/files/compress.go
Outdated
| os.MkdirAll(workDir, 0755) | ||
| err = os.MkdirAll(workDir, 0755) | ||
| if err != nil { | ||
| return errors.Wrap(err, "can't prepare work directory") |
There was a problem hiding this comment.
nit: errors.Wrapf( ..., workDir)?
There was a problem hiding this comment.
That will be in the underlying os.PathError, but done. pkg/errors makes me sad.
Makefile
Outdated
|
|
||
| test-go: | ||
| test-build-dir: | ||
| mkdir -p $(PWD)/build/test-results |
There was a problem hiding this comment.
That's funny as @stuartnelson3 found it in the same time here :)
I would ask you or @stuartnelson3 to extract changes in Makefile to a separate PR.
There was a problem hiding this comment.
Ok, @stuartnelson3 did this already (thanks!). Would you mind adjusting your PR?
mtojek
changed the title
mtojek
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to remove magic constants, handle errors and clean up.
Some changes requested by opinionated editor/linter.
Makefile fixed to ensure that build directory exists before starting work.
Please take a look.