-
Couldn't load subscription status.
- Fork 128
Upgrade mongo driver #565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade mongo driver #565
Conversation
need to upgrade strfmt to upgrade mongo-driver, which has an open CVE for the version used
test folder wasn't being created if absent
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is more like a formal action that fixing a real issue. We don't use mongo libraries, it's just a transitive dependency as you noticed.
Makefile
Outdated
| update: update-readme | ||
|
|
||
| test-go: | ||
| $(CODE_COVERAGE_REPORT_NAME_UNIT): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is about upgrading the mongo-driver as there is a moderate security alert, but I'm having hard times understanding all other changes in Makefile. Could you please explain why did you introduce this? Did you face any issue around these? The CODE_COVERAGE_REPORT_NAME_UNIT directory is created by the tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked into this deeper and agree that there is an issue. Would you mind extracting it to a separate PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I encountered this while running the tests. I'll open a separate PR.
This reverts commit 5e2a348.
this is true. still, it removes a moderate security alert for both |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose we're good to merge this one.
this was prompted by a security warning for
mongo-driverin apm-server. after bumping the version, tests seem to be passing, so maybe it was as simple as the below command. I checked the dependency graph and upgraded to the lateststrfmt:after upgrade:
closes #564