Skip to content

Conversation

@ohueter
Copy link

@ohueter ohueter commented Aug 10, 2022

This PR changes the function_score type in the QueryDslQueryContainer interface from

interface QueryDslQueryContainer {
  function_score?: QueryDslFunctionScoreQuery
}

to

interface QueryDslQueryContainer {
  function_score?: QueryDslFunctionScoreQuery | QueryDslFunctionScoreContainer
}

I'm not sure if any additional files need to be changed or code needs to be auto-generated? Would appreciate your help, thanks!

Fixes elastic/elasticsearch-specification#2109

Update: Signed the contributor agreement.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@cla-checker-service
Copy link

cla-checker-service bot commented Aug 10, 2022

💚 CLA has been signed

@JoshMock
Copy link
Member

closing based on @swallez's comment on the spec. currently investigating a more appropriate solution.

@JoshMock JoshMock closed this Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

function_score type in QueryDslQueryContainer interface seems incorrect

3 participants