supporting blog content langgraph-js-elasticsearch #494
Conversation
|
Review these changes at https://app.gitnotebooks.com/elastic/elasticsearch-labs/pull/494 |
|
@llermaly is this coming from a fork? If so the PR checks won't pass. It will need to come from a branch. |
|
Can you add a README file to the folder explaining how to install and run the code? |
|
Hi @carlyrichmond! Added the README file! Regarding the pull request: we’ve always opened PRs from a fork, and I created a new branch there specifically for this content. I’m not sure if there’s a new way to handle contributions, if that’s the case, please let me know. Thanks! |
| } | ||
|
|
||
| // Node 4: Visualize results | ||
| async function visualizeResults(state: typeof VCState.State) { |
There was a problem hiding this comment.
I would say the term visualize here is misleading as you're not presenting the data on a chart or anything. Perhaps formatResults would make more sense?
| }; | ||
| } | ||
|
|
||
| async function saveGraphImage(app: any): Promise<void> { |
There was a problem hiding this comment.
I would add a comment explaining what this function does.
| const query = | ||
| "Find startups with Series A or Series B funding between $8M-$25M and monthly revenue above $500K"; | ||
|
|
||
| // Market-focused query (emphasizes industry, geography, market positioning) |
There was a problem hiding this comment.
Can you have both uncommented and then run them one after the other and show the results? I always find commented code in examples to be really untidy.
3 participants
No description provided.