Fix HttpWebRequestConnection running under netcoreapp

The following is not allowed to be set anymore

 			request.MaximumResponseHeadersLength = -1;

Further more we need to explicitly provide a proxy for this IConnection
when the tests are automatically routing through fiddler by using
ipv4.fiddler

Author: Mpdreamz

src/Elasticsearch.Net/Connection/HttpWebRequestConnection.cs

@@ -57,7 +57,9 @@ protected virtual HttpWebRequest CreateWebRequest(RequestData requestData)
 
 			request.Accept = requestData.Accept;
 			request.ContentType = requestData.RequestMimeType;
+#if !DOTNETCORE
 			request.MaximumResponseHeadersLength = -1;
+#endif
 			request.Pipelined = requestData.Pipelined;
 
 			if (requestData.HttpCompression)

src/Tests/Tests.ClusterLauncher/ClusterLaunchProgram.cs

@@ -71,7 +71,7 @@ private static Type[] GetClusters()
 
 			try
 			{
-				types = typeof(ClusterLaunchProgram).GetTypeInfo().Assembly.GetTypes();
+				types = typeof(INestTestCluster).GetTypeInfo().Assembly.GetTypes();
 			}
 			catch (ReflectionTypeLoadException e)
 			{

src/Tests/Tests.Configuration/tests.default.yaml

@@ -18,4 +18,4 @@ elasticsearch_version: 6.3.0
 test_against_already_running_elasticsearch: true
 
 #random_source_serializer: true
-seed: 69819
+seed: 46221

src/Tests/Tests.Core/Client/Settings/TestConnectionSettings.cs

@@ -38,6 +38,7 @@ public TestConnectionSettings(
 				: ConnectionConfiguration.DefaultConnectionLimit;
 
 		internal ConnectionSettings ApplyTestSettings() => this
+			.ApplyFiddlerProxyWhenNeeded()
 			//TODO make this random
 			//.EnableHttpCompression()
 #if DEBUG
@@ -53,6 +54,13 @@ internal ConnectionSettings ApplyTestSettings() => this
 				foreach (var d in r.DeprecationWarnings) XunitRunState.SeenDeprecations.Add(d);
 			});
 
+		private ConnectionSettings ApplyFiddlerProxyWhenNeeded()
+		{
+			if (!TestConfiguration.Instance.Random.OldConnection) return this;
+			if (!RunningFiddler) return this;
+			return this.Proxy(new Uri("http://localhost:8888"), null, null);
+		}
+
 		private static SourceSerializerFactory CreateSerializerFactory(SourceSerializerFactory provided)
 		{
 			if (provided != null) return provided;

src/Tests/Tests.Core/Extensions/EphemeralClusterExtensions.cs

@@ -10,14 +10,10 @@ namespace Tests.Core.Extensions
 {
 	public static class EphemeralClusterExtensions
 	{
-		public static ConnectionSettings CreateConnectionSettings<TConfig>(
-			this IEphemeralCluster<TConfig> cluster
-			)
+		public static ConnectionSettings CreateConnectionSettings<TConfig>(this IEphemeralCluster<TConfig> cluster)
 			where TConfig : EphemeralClusterConfiguration
 		{
-			var clusterNodes = cluster.NodesUris(TestConnectionSettings.LocalOrProxyHost);
-			//we ignore the uri's that TestConnection provides and seed with the nodes the cluster dictates.
-			return new TestConnectionSettings(uris => new StaticConnectionPool(clusterNodes));
+			return new TestConnectionSettings();
 		}
 
 		public static IElasticClient GetOrAddClient<TConfig>(

src/Tests/Tests.Core/ManagedElasticsearch/Clusters/ClientTestClusterBase.cs

@@ -24,7 +24,7 @@ public ClientTestClusterBase(params ElasticsearchPlugin[] plugins) : this(new Cl
 
 		public ClientTestClusterBase(ClientTestClusterConfiguration configuration) : base(configuration) { }
 
-		public IElasticClient Client => this.GetOrAddClient(s=> this.ConnectionSettings(ConnectionSettingsExtensions.ApplyDomainSettings(s)));
+		public IElasticClient Client => this.GetOrAddClient(s=> this.ConnectionSettings(s.ApplyDomainSettings()));
 
 		protected virtual ConnectionSettings ConnectionSettings(ConnectionSettings s) => s;