GetIndexSettings response properties not filled correctly

[EricKeij]

NEST/Elasticsearch.Net version: 2.3.1

Elasticsearch version: 2.3.1

Description of the problem including expected versus actual behavior:
When doing GetIndexSettings() I expect the NumberOfReplicas and NumberOfShards properties to be set. Instead they will always be null.

Steps to reproduce:

1. Do a GetIndexSettings()

var response = ElasticClient.GetIndexSettings(d => d.Index("myindex"))

1. Check value of NumberOfReplicas and NumberOfShards which will always be null.

var numberOfReplicas = response.Indices.Single(i => i == "myindex").Value.Settings.NumberOfReplicas;

A workaround is the get the value directly from the dictionary using:

var numberOfReplicas = response.Indices.Single(i => i == "myindex").Value.Settings.Single( x => x.Key == "index.NumberOfReplicas").Value

[Mpdreamz]

Hi @EricKeij tried to reproduce this locally but to no avail

The correct elasticsearch setting is index.number_of_replicas which is what we serialize to and deserialize from.

937019b

I did notice in our 5.x beta branch we had a bug where number_of_replicas got overwritten to null at serialization time. This is not the case in the stable 2.x brranches.

I do wonder how index.NumberOfReplicas got serialized into the index's settiings. Can you share the code that puts it there in the first place?

[EricKeij]

It turned out we use numberOfShards and numberOfReplicas in our templates instead of number_of_shards and number_of_replicas. Both seems to be valid (at least both work). I changed our templates to number_of_shards and number_of_replicas which solves our problem.

[Mpdreamz]

Aye that will explain the origin of the camelCasing :)

camelCase support is deprecated in 2.x and scheduled for removal in 5.x

elastic/elasticsearch#17933

That said we should make an effort supporting camelCase settings at read time in our 2.x branch.

[Mpdreamz]

We now also read camelCase versions of known values such as index.numberOfShards in 2.x as per 65bb0ab

@EricKeij index.NumberOfShards in PascalCase is not supported in Elasticsearch 2.x. Your second comment is in camelCase but first in PascalCase.

Just want to stress that sending "index.NumberOfShards" : 2 won't actually create 2 shards in Elasticsearch 2.x. "index.numberOfShards" : 2 will work but is deprecated.