Update<T,K>

[NeilMenne]

So I'm trying to pass a partial update this way (http://stackoverflow.com/a/23796603) in a test as well as in the production code that utilizes Nest. When I do this, the test never completes execution. It hangs indefinitely in the Client.Update<Load, object> function.

The reason I began investigating this approach was I was trying to use a new instance of Load to do the partial update and information in the Total field was lost.

My fix in the meantime is to use nullable fields for those that get overwritten i.e. int? instead of int and double? instead of double.

A simplified version of my class:

[ElasticType(Name = "load",
    IdProperty = "Id")]
public class Load
{
    public int Id { get; set; }

    public int CustomerId { get; set; }

    public string CustomerName { get; set; }

    public double Total { get; set; }
}

tl;dr: Unexpected behavior for Update<T,K> when Document is given a dynamic object

[NeilMenne]

Another temporary fix (incase anyone else is having this problem) is to do a bulk update of one item.

[gmarz]

@NeilMenne Mind posting your test to try and reproduce this? See the test above that I just pushed which uses a dynamic object to perform an update- it worked as expected.

[NeilMenne]

    [TestMethod]
    public void TestUpdateUsingPartial()
    {
        Load load = new Load
        {
            Id = 1,
            CustomerId = 3,
            CustomerName = "Customer",
            Total = 0.00
        };

        _nestLoad.IndexLoad(load);

        dynamic partial_load = new ExpandoObject();
        partial_load.Id = load.Id;
        partial_load.CustomerId = 3;

        Assert.IsTrue(_nestLoad.UpdateLoad(partial_load));
    }

    [TestMethod]
    public void TestUpdateUsingPartialAndBulk()
    {
        Load load = new Load
        {
            Id = 2,
            CustomerId = 3,
            CustomerName = "Other",
            Total = 1.00
        };

        _nestLoad.IndexLoad(load);

        dynamic partial_load = new ExpandoObject();
        partial_load.Id = load.Id;
        partial_load.CustomerId = 3;

        Assert.IsTrue(_nestLoad.UpdateViaBulk(partial_load));
    }

Where UpdateLoad looks like:

    public bool UpdateLoad(dynamic partial)
    {
        IUpdateResponse response = Client.Update<Load, object>(u => u
            .Id(partial.Id)
            .Document(partial)
            );
        return response.IsValid;
    }

UpdateViaBulk looks like:

    public bool UpdateViaBulk(dynamic partial)
    {
        IBulkResponse response = Client.Bulk(b => b
            .Update<Load, dynamic>(u => u
                .Document(partial)
                .Id(partial.Id)
            ));

        return response.IsValid;
    }

UpdateViaBulk passes. UpdateLoad hangs indefinitely.

[Mpdreamz]

The reason it was hanging here is because the dynamic was cloaking the fact that

.Document(partial)

In this case is not valid since partial is not of type Load

I've attached a commit with your unit tests and made them green.

Somewhat related is this PR #795 which should streamline the update API to be somewhat less confusing.

.Document here is only used to infer the Id not to send the actual partial update.

[NeilMenne]

That makes sense. I was going back and forth between your documentation and Elasticsearch's.

Thanks for the help!