Skip to content

Added File property to SortSearchDescriptor #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Added File property to SortSearchDescriptor #1250

wants to merge 2 commits into from

Conversation

@nickelbob
Copy link

@nickelbob nickelbob commented Feb 16, 2015

I installed the editorconfig extension but my formatting still seems messed up, sorry about that.

@nickelbob
Copy link
Author

nickelbob commented Feb 16, 2015

Well, that didn't go so well. I just signed the CLA so maybe that's not updated yet.

Not sure why the project isn't building. If anyone knows offhand please comment and I'll fix it as soon as possible.

Thanks!

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 17, 2015

Hey @nickelbob thanks for the PR!

The CLA checks git emails with the email you used to sign the CLA, I can see you've signed it though.

The travis build still has hiccups now that we moved to paket which sometimes returns an error code while restoring it seems, I restarted the travis build manually and it seems fine now.

Mpdreamz pushed a commit that referenced this pull request Feb 17, 2015
@Mpdreamz
Squashed commits in #1250 with formatting fixes
05ac23d 
fixed formatting changes introduced in #1250

#1249 Changed formatting, added test

#1249 Added File property to SortSearchDescriptor
@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 17, 2015

Squashed your commits with my formatting fixes so your changes come through cleanly, thanks again for the PR!

@Mpdreamz Mpdreamz closed this Feb 17, 2015
@Mpdreamz Mpdreamz mentioned this pull request Feb 17, 2015
Closed
@gmarz gmarz added the v1.4.2 label Feb 17, 2015
@nickelbob
Copy link
Author

nickelbob commented Feb 17, 2015

Nice! Thanks so much for your help Martijn and thanks for Elasticsearch.Net! We use it more and more everyday and it's such a great selling point for .NET shops to get into Elasticsearch.

Thanks again!

@Mpdreamz
Copy link
Member

Mpdreamz commented Feb 17, 2015

Glad to hear! Positive vibes much appreciated 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nickelbob @Mpdreamz @gmarz