Skip to content

Feature/variable suffix #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 6, 2015
Merged

Feature/variable suffix #1380

merged 4 commits into from
May 6, 2015

Conversation

@Mpdreamz
Copy link
Member

@Mpdreamz Mpdreamz commented May 6, 2015

Adds support var using variables in Suffix() expressions as requested in #998

e.g:

var prop = "propXY12";
P(p => p.Name.Suffix(prop)).Should().Be("name.propXY12");

This PR also fixes a bug where IDictionary<TKey, TValue> expressions would fail unexpectedly where `Dictionary<Tkey, TValue> worked fine.

@gmarz
Copy link
Contributor

gmarz commented May 6, 2015

Nice! LGTM 👍

gmarz added a commit that referenced this pull request May 6, 2015
@gmarz
Merge pull request #1380 from elastic/feature/variable-suffix
7cb1309 
Feature/variable suffix
@gmarz gmarz merged commit 7cb1309 into develop May 6, 2015
@gmarz gmarz deleted the feature/variable-suffix branch May 6, 2015 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Mpdreamz @gmarz