Skip to content

UriInfo class is improperly parsing URIs #1651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

UriInfo class is improperly parsing URIs #1651

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/Elasticsearch.Net/Purify/Purify.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System;
using System.Globalization;
using System.Reflection;

namespace Purify
Expand Down Expand Up @@ -180,8 +181,20 @@ public UriInfo(Uri uri, string source)
var pathEnd = queryPos == -1 ? fragPos : queryPos;
if (pathEnd == -1)
pathEnd = source.Length + 1;

if (start < pathEnd - 1 && source[start] == ':')
{
var portLength = uri.Port.ToString(CultureInfo.InvariantCulture).Length;
start += portLength + 1;
}

Path = queryPos > -1 ? source.Substring(start, pathEnd - start) : source.Substring(start);
Query = fragPos > -1 ? source.Substring(queryPos, fragPos - queryPos) : source.Substring(queryPos);

Query = fragPos > -1
? source.Substring(queryPos, fragPos - queryPos)
: queryPos > -1
? source.Substring(queryPos, (source.Length - queryPos))
: null;
}
}
}
Expand Down