Sticky Connection Pool #1831
Merged
Sticky Connection Pool #1831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always return the lowest alive node in the sequence they were provided
Should try each node in turn if still failing
This is currently skipped as i'm not sure how to make it work as expected using the test framework.
Member
Mpdreamz
added a commit
that referenced
this pull request
Feb 19, 2016
Member
|
Thank you for taking the challenge @Romanx 👍 merged this in today 😄 |
Contributor
Author
|
@Mpdreamz Thanks for letting me have a stab, hopefully it all makes sense. Sorry about the formatting of the commit, didn't realise I didn't have the editor config plugin installed! |
Contributor
Author
|
@Mpdreamz did you get to look at the skipped test? I struggled with finding a way to do what I wanted to test with the current test framework, if there's a way i'd be willing to fix up that test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1810
Not ready for merging and requires feedback. There's one skipped test which I wasn't sure how to do using your test framework,
If you could take a look and provide feedback if their is a way. If not it might be worth investing in making a way as it's a slightly more advanced use case than the other tests I found, hopefully the test explains itself well enough, otherwise just ask.
Test can be found in this commit 8d1906a