fix #2164 you can now skip the create index step if you use our Reind… #2434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
force-pushed
the
fix/reindex-helper-improvements
branch
from
5318315 to
3a64d95
Compare
gmarz
approved these changes
Nov 30, 2016
Contributor
gmarz
left a comment
gmarz
left a comment
There was a problem hiding this comment.
LGTM 👍 My only comment is to maybe rename OmitCreateIndex to OmitIndexCreation.
…ex() helper, also made sure we use a _doc sort on the scroll
Mpdreamz
force-pushed
the
fix/reindex-helper-improvements
branch
from
3a64d95 to
49f24cd
Compare
Member
Author
|
++ to name change added that in as well, thanks @gmarz. |
Mpdreamz
added a commit
that referenced
this pull request
Nov 30, 2016
…ex() helper, also made sure we use a _doc sort on the scroll (#2434)
Mpdreamz
added a commit
that referenced
this pull request
Nov 30, 2016
…tation deviates too much (#2435)
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
…r Reindex() helper, also made sure we use a _doc sort on the scroll (elastic#2434)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ex() helper, also made sure we use a _doc sort on the scroll