Add deserialization method for TermsIncludeExclude #2508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Dec 28, 2016
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM moved to manual serialization tests over to roundtripper so that we assert a full read->write->read cycle
Mpdreamz
pushed a commit
that referenced
this pull request
Dec 28, 2016
* Add deserialization method for TermsIncludeExclude Fixes #2503 * moved manual deserializing to RoundTripper Conflicts: src/Nest/Aggregations/Bucket/Terms/TermsIncludeExcludeJsonConverter.cs src/Tests/Tests.csproj
Mpdreamz
pushed a commit
that referenced
this pull request
Dec 28, 2016
* Add deserialization method for TermsIncludeExclude Fixes #2503 * moved manual deserializing to RoundTripper Conflicts: src/Nest/Aggregations/Bucket/Terms/TermsIncludeExcludeJsonConverter.cs src/Tests/Tests.csproj
Member
|
ported to |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* Add deserialization method for TermsIncludeExclude Fixes elastic#2503 * moved manual deserializing to RoundTripper Conflicts: src/Nest/Aggregations/Bucket/Terms/TermsIncludeExcludeJsonConverter.cs src/Tests/Tests.csproj
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2503