Fix #2573 bwc support for new cluster allocation explain response #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Feb 14, 2017
| [JsonProperty("assigned")] | ||
| bool Assigned { get; } | ||
| [JsonIgnore] | ||
| // TODO rename to Shard in 6.0 |
Member
There was a problem hiding this comment.
[Obsolete())] straight away? or do we start doing that when 6.0 hits?
Contributor
Author
There was a problem hiding this comment.
Hmm...marking obsolete isn't great either because there's no alternative right now.
Contributor
Author
|
Merged to 5.x and ported to master |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new properties introduced in ES 5.2 and marks the old ones obsolete.
Test old against new:
build integrate 5.1.2 unbalanced ClusterAllocationExplainResponseApiTestsTest old against old:
build integrate 5.1.2 unbalanced ClusterAllocationExplainResponseOldApiTestsTest new against new:
build integrate 5.2.0 unbalanced ClusterAllocationExplainResponseNewApiTests