Feature/5.x build output #2806
Merged
Feature/5.x build output #2806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mpdreamz
approved these changes
Jul 25, 2017
| <dependency id="System.Linq.Queryable" version="[4.0.1, )" /> | ||
| <dependency id="Elasticsearch.Net" version="[$version$, $nextMajorVersion$)" /> | ||
| <dependency id="Newtonsoft.Json" version="[10,11)" /> | ||
| <dependency id="Newtonsoft.Json" version="[$jsonDotNetCurrentVersion$, $jsonDotNetNextVersion$)" /> |
| DotNetProject.All |> Seq.iter(fun p -> CleanDir(Paths.BinFolder p.Name)) | ||
| | (_, _) -> | ||
| tracefn "Skiping clean target only run when calling 'release', 'canary', 'clean' as targets directly" | ||
| tracefn "Skipping clean target only run when calling 'release', 'canary', 'clean' as targets directly" |
|
|
||
| let year = sprintf "%i" DateTime.UtcNow.Year | ||
|
|
||
| let jsonDotNetVersion = 10 |
Member
There was a problem hiding this comment.
Would have given this PR ⭐️⭐️⭐️⭐️⭐️ had this been read from our csproj files.
That said, submitting a PR that brings us back to paket soon so might have been waisted effort.
| let buildVersion = if (isNullOrEmpty bv) then None else Some(parse(bv)) | ||
| match (getBuildParam "target", buildVersion) with | ||
| | ("release", None) -> failwithf "can not run release because no explicit version number was passed on the command line" | ||
| | ("release", None) -> failwithf "cannot run release because no explicit version number was passed on the command line" |
russcam
force-pushed
the
feature/5.x-build-output
branch
from
daa0d0c to
76b696c
Compare
russcam
added a commit
that referenced
this pull request
Jul 26, 2017
* build projects to build/output * Parameterize JSON.Net dependency (cherry picked from commit 98ae32b)
russcam
added a commit
that referenced
this pull request
Jul 26, 2017
* build projects to build/output * Parameterize JSON.Net dependency (cherry picked from commit 98ae32b)
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
* build projects to build/output * Parameterize JSON.Net dependency (cherry picked from commit 98ae32b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a return to outputting the build for all projects from the command line to
build/output. All projects build there with the following dir structurebuild/output/<Project>/<TFM>build/outputPathsmodule