Add branch name to benchmarking results, add command line parameter #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russcam
suggested changes
Aug 10, 2017
Contributor
russcam
left a comment
russcam
left a comment
There was a problem hiding this comment.
2 very minor nitpicks, LGTM otherwise
build/scripts/Benchmarking.fsx
Outdated
|
|
||
| let date = DateTime.UtcNow | ||
| let commit = getSHA1 "." "HEAD" | ||
| let branchName = getBranchName "." |
Contributor
There was a problem hiding this comment.
minor nitpick: space alignment
build/scripts/Commandline.fsx
Outdated
|
|
||
| | ["test"; testFilter] -> setBuildParam "testfilter" testFilter | ||
|
|
||
| | ["benchmark"; "non-interactive"; IsUrl elasticsearch; username; password] -> |
Contributor
There was a problem hiding this comment.
I think "non-interactive" should be the last argument, to align with the conventions of the other patterns.
russcam
approved these changes
Aug 10, 2017
codebrain
pushed a commit
that referenced
this pull request
Aug 10, 2017
…2827) * Add branch name to benchmarking results, add command line parameter.
codebrain
pushed a commit
that referenced
this pull request
Aug 10, 2017
…2827) * Add branch name to benchmarking results, add command line parameter.
Contributor
|
@codebrain needs cherry-picking/backporting to 5.x and 2.x |
awelburn
pushed a commit
to Artesian/elasticsearch-net
that referenced
this pull request
Nov 6, 2017
…lastic#2827) * Add branch name to benchmarking results, add command line parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add branchname and setup Team City command line version.