6.0 Script changes #2951
Merged
6.0 Script changes #2951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Groovy, JavaScript, and Python languages removededit The Groovy, JavaScript, and Python scripting languages were deprecated in elasticsearch 5.0 and have now been removed. Use painless instead. - lang can no longer be specified when using a stored script as part of a requestedit The lang variable can no longer be specified as part of a request that uses a stored script otherwise an error will occur. Note that a request using a stored script is different from a request that puts a stored script. The language of the script has already been stored as part of the cluster state and an id is sufficient to access all of the information necessary to execute a stored script. - lang can no longer be used when putting, getting, or deleting a stored scriptedit Stored scripts can no longer have the lang parameter specified as part of the url when performing PUT, GET, and DELETE actions on the _scripts/ path. All stored scripts must have a unique id as the namespace is only id now and no longer lang and id.
Mpdreamz
requested changes
Dec 13, 2017
| [JsonConverter(typeof(ReadAsTypeJsonConverter<StoredScript>))] | ||
| public interface IStoredScript | ||
| { | ||
| [JsonProperty("lang")] |
Member
There was a problem hiding this comment.
You can still specify lang as part of the body, its just no longer part of the path in the url:
| private static readonly string Lang = ScriptLang.Expression.GetStringValue(); | ||
| public LuceneExpressionScript(string source) : base(Lang, source) { } | ||
| } | ||
| public class MustacheScript : StoredScript |
Member
There was a problem hiding this comment.
| private static readonly string Lang = ScriptLang.Python.GetStringValue(); | ||
| public PythonScript(string source) : base(Lang, source) { } | ||
| } | ||
| public class LuceneExpressionScript : StoredScript |
Member
There was a problem hiding this comment.
I think we should keep this one around:
| public PutScriptDescriptor Groovy(string source) => Assign(a => a.Script = new GroovyScript(source)); | ||
| public PutScriptDescriptor JavaScript(string source) => Assign(a => a.Script = new JavaScriptScript(source)); | ||
| public PutScriptDescriptor Python(string source) => Assign(a => a.Script = new PythonScript(source)); | ||
| public PutScriptDescriptor LuceneExpression(string source) => Assign(a => a.Script = new LuceneExpressionScript(source)); |
Member
There was a problem hiding this comment.
Keep LuceneExpression and Mustache
Remove no longer supported languages from ScriptLang enum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR may contradict breaking change information here: https://www.elastic.co/guide/en/elasticsearch/reference/current/breaking_60_scripting_changes.html#_stored_search_template_apis_removed
Groovy, JavaScript, and Python languages removed
The Groovy, JavaScript, and Python scripting languages were deprecated in elasticsearch 5.0 and have now been removed. Use painless instead.
lang can no longer be specified when using a stored script as part of a request
The lang variable can no longer be specified as part of a request that uses a stored script otherwise an error will occur. Note that a request using a stored script is different from a request that puts a stored script. The language of the script has already been stored as part of the cluster state and an id is sufficient to access all of the information necessary to execute a stored script.
lang can no longer be used when putting, getting, or deleting a stored script
Stored scripts can no longer have the lang parameter specified as part of the url when performing PUT, GET, and DELETE actions on the _scripts/ path. All stored scripts must have a unique id as the namespace is only id now and no longer lang and id.
Addresses: #2935
and items on #2923