Re-add Aggregation usage examples #3075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit re-adds aggregation usage examples back into the documentation. Refactoring as part of 6.0 introduced aggregation related fluent, initializer and expectjson properties which are not picked up by the Usages Roslyn walker/visitor.
Mpdreamz
requested changes
Feb 5, 2018
| ==== Client Certificates | ||
|
|
||
| X-Pack also allows you to configure a {xpack_current}/pki-realm.html[PKI realm] to enable user authentication | ||
| through client certificates. The {ref_current}/certutil.html[+certutil+ tool] included with X-Pack allows you to |
Member
There was a problem hiding this comment.
Is this the correct way ? We broke the doc build on this before not sure if this ends up reverting it?
Contributor
Author
There was a problem hiding this comment.
That link looks fine there, but I'll double check. If I get a chance today, I'll take a look at AsciiDocNet
russcam
added a commit
that referenced
this pull request
Feb 6, 2018
* Re-add Aggregation usage examples This commit re-adds aggregation usage examples back into the documentation. Refactoring as part of 6.0 introduced aggregation related fluent, initializer and expectjson properties which are not picked up by the Usages Roslyn walker/visitor. * Regenerate documentation (cherry picked from commit f998ef7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-adds aggregation usage examples back into the documentation. Refactoring as part of 6.0 introduced aggregation related fluent, initializer and expectjson properties which are not picked up by the Usages Roslyn walker/visitor.