Skip to content

Conversation

@russcam
Copy link
Contributor

@russcam russcam commented Apr 16, 2018

This commit adds support for the ip_range datatype.
The existing IpRange type used for IpRangeAggregation renamed to
IpRangeAggregationRange to allow for the introduction of an IpRange type
whose name aligns with other range datatypes.

Closes #3118

This commit adds support for the ip_range datatype.
The existing IpRange type used for IpRangeAggregation renamed to
IpRangeAggregationRange to allow for the introduction of an IpRange type
whose name aligns with other range datatypes.

Closes #3118
@russcam
Copy link
Contributor Author

russcam commented Apr 16, 2018

Will need to be backported to 6.x and 5.x in a BWC way i.e. IpRange cannot be renamed in those branches, so the type representing ip_range datatype will need to be named differently - IpAddressRange?

@codebrain
Copy link
Contributor

LGTM

@codebrain codebrain merged commit db8c524 into master Apr 26, 2018
@codebrain codebrain self-assigned this Apr 26, 2018
codebrain added a commit that referenced this pull request Apr 26, 2018
codebrain added a commit that referenced this pull request Apr 26, 2018
This commit adds support for the ip_range datatype.
The existing IpRange type used for IpRangeAggregation renamed to
IpRangeAggregationRange to allow for the introduction of an IpRange type
whose name aligns with other range datatypes.
codebrain pushed a commit that referenced this pull request Apr 27, 2018
Backport of #3202 to 5.x

This commit adds support for the ip_range datatype.
The existing IpRange type used for IpRangeAggregation renamed to
IpRangeAggregationRange to allow for the introduction of an IpRange type
whose name aligns with other range datatypes.
codebrain pushed a commit that referenced this pull request Apr 27, 2018
Add support for ip_range datatype (Backport of #3202 to 6.x)

This commit adds support for the ip_range datatype.
The existing IpRange type used for IpRangeAggregation renamed to
IpRangeAggregationRange to allow for the introduction of an IpRange type
whose name aligns with other range datatypes.
@russcam russcam deleted the feature/ip-range branch April 28, 2018 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants